On Wed, Dec 11, 2013 at 11:25 AM, Andres Freund <and...@2ndquadrant.com> wrote: > On 2013-12-10 19:11:03 -0500, Robert Haas wrote: >> Committed #1 (again). Regarding this: >> >> + /* XXX: we could also do this unconditionally, the space is used >> anyway >> + if (copy_oid) >> + HeapTupleSetOid(key_tuple, HeapTupleGetOid(tp)); >> >> I would like to put in a big +1 for doing that unconditionally. I >> didn't make that change before committing, but I think it'd be a very >> good idea. > > Patch attached.
Committed with kibitzing. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers