I wrote: > I wrote: > > Kyotaro HORIGUCHI wrote: > > > > * In get_relation_info(), the patch determines the branch > > > > condition "keyattno != ObjectIdAttributeNumber". I fail to > > > > understand the meaning of this branch condition. Could you explain > about it?
> > > Literally answering, it means oid cannot be NULL (if it exists). > > Understood. Thank you for the detailed information. But I'm not sure > > it's worth complicating the code. What use cases are you thinking? > Having said that, I've reconsidered about this, and start to think it would > be better that all system attributes are processed in the same way as are > user attributes because that makes the code more simple. Yes, as you > mention, it's not necessarily guaranteed that system attributes have the > uniqueness property in general, but that's another problem. I've modified the patch to work in such a way. Also, as ISTM the patch is more complicated than what the patch really does, I've simplified the patch. Attached is an updated version of the patch. Could you review the patch? Thanks, Best regards, Etsuro Fujita
pathkey_and_uniqueindx_v6_20131128.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
