Following are my initial comments for https://commitfest.postgresql.org/action/patch_view?id=1203
1. It no longer applies, probably due to commit a18167510f4c385329697588ce5132cbf95779c3 error: contrib/hstore/hstore--1.1.sql: No such file or directory 2. Compatibility with HStore v2.0 (https://commitfest.postgresql.org/action/patch_view?id=1289) As long as the separate operator class gin_hstore_combined_ops is used, there should be no conflict. I'll verify as soon as the $subject patch is applicable to master. 3. Regression tests Shouldn't EXPLAIN be there too? I suggest a test that creates 2 indexes on the hstore column - one using the existing GIN (default) opclass and one using the new one (combined). The execution plan will then show if an index is used and if it's the correct one. // Antonin Houska (Tony) -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
