Tom Lane wrote: > Teodor Sigaev <[EMAIL PROTECTED]> writes: > > gcc -g -O -Wall -Wmissing-prototypes -Wmissing-declarations > > -I../../../src/include -c -o copy.o copy.c > > copy.c: In function `CopyFrom': > > copy.c:1130: warning: passing arg 1 of `coerce_type_constraints' from > > incompatible pointer type > > copy.c:1130: warning: passing arg 2 of `coerce_type_constraints' makes integer > > from pointer without a cast > > copy.c:1130: too many arguments to function `coerce_type_constraints' > > Looks like Rod's domain-constraints-in-COPY patch was stale after my > recent casting changes. Will work on it ... > > (Bruce, you really oughta do some minimal testing on patches before > committing 'em.)
OK, patch attached. Tom, what is the proper third parameter in COPY, COERCE_DONTCARE? -- Bruce Momjian | http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
Index: src/backend/commands/copy.c =================================================================== RCS file: /cvsroot/pgsql-server/src/backend/commands/copy.c,v retrieving revision 1.172 diff -c -c -r1.172 copy.c *** src/backend/commands/copy.c 20 Sep 2002 03:52:50 -0000 1.172 --- src/backend/commands/copy.c 20 Sep 2002 15:28:42 -0000 *************** *** 1126,1133 **** false); /* not coerced */ /* Process constraints */ ! node = coerce_type_constraints(pstate, (Node *) con, ! attr[m]->atttypid, true); values[m] = ExecEvalExpr(node, econtext, &isNull, NULL); --- 1126,1133 ---- false); /* not coerced */ /* Process constraints */ ! node = coerce_type_constraints((Node *) con, attr[m]->atttypid, ! COERCE_DONTCARE); values[m] = ExecEvalExpr(node, econtext, &isNull, NULL);
---------------------------(end of broadcast)--------------------------- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly