On 08.11.2013 19:14, Tom Lane wrote:
Heikki Linnakangas <hlinnakan...@vmware.com> writes:
I came up with the attached fix. In a nutshell, when walking along a
right-link, the new page is locked before releasing the lock on the old
one. Also, never delete the leftmost branch of a posting tree. I believe
these changes are sufficient to fix the problem, because of the way the
posting tree is searched:
This seems reasonable, but I wonder whether the concurrency discussion
shouldn't be in gist/README, rather than buried in a comment inside
ginDeletePage (not exactly the first place one would think to look IMO).
Yeah, README is probably better. There's zero explanation of concurrency
and locking issues there at the moment, so I added a new section there
explaining why the page deletion is (now) safe. There's a lot more to
say about locking in GIN, but I'll leave that for another day.
- Heikki
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
