On 2013-11-01 15:28:54 -0400, Tom Lane wrote: > Andres Freund <and...@2ndquadrant.com> writes: > > While not particularly nice, given the API, it seems best for buffile.c > > to remember the resource owner used for the original segment and > > temporarily set that during the extension. > > Hm, yeah, that seems right. It's just like repalloc keeping the memory > chunk in its original context. The comments here are a bit inadequate...
Thanks for committing and sorry for the need to freshen up the comments. I don't think I had ever opened buffile.c before and thus wasn't sure if there isn't a better fix, so I didn't want to spend too much time on it before somebody agreed it is the right fix. Also, I was actually just trying to recover some data from a corrupted database and this stopped me from it ;) Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
