Sounds good. I personally don't have any interest in log file i/o counters, but that's just me. I wonder if stats collector counters might be useful... I seem to recall an effort to improve that area. Maybe not enough use to take the performance hit on a regular basis, though.
__________________________________________________________________________________ *Mike Blackwell | Technical Analyst, Distribution Services/Rollout Management | RR Donnelley* 1750 Wallace Ave | St Charles, IL 60174-3401 Office: 630.313.7818 mike.blackw...@rrd.com http://www.rrdonnelley.com <http://www.rrdonnelley.com/> * <mike.blackw...@rrd.com>* On Wed, Oct 23, 2013 at 1:44 PM, Nigel Heron <nhe...@querymetrics.com>wrote: > Hi, thanks, I'm still actively working on this patch. I've gotten the > traffic counters working when using SSL enabled clients (includes the > ssl overhead now) but I still have the walsender transfers under SSL > to work on. > I'll post an updated patch when i have it figured out. > Since the patch changes some views in pg_catalog, a regression test > fails .. i'm not sure what to do next. Change the regression test in > the patch, or wait until the review phase? > > I was also thinking of adding global counters for the stats collector > (pg_stat* file read/write bytes + packets lost) and also log file io > (bytes written for txt and csv formats) .. any interest? > > -nigel. > > On Wed, Oct 23, 2013 at 12:50 PM, Mike Blackwell <mike.blackw...@rrd.com> > wrote: > > I added this to the current CF, and am starting to review it as I have > time. > > > > > __________________________________________________________________________________ > > Mike Blackwell | Technical Analyst, Distribution Services/Rollout > Management > > | RR Donnelley > > 1750 Wallace Ave | St Charles, IL 60174-3401 > > Office: 630.313.7818 > > mike.blackw...@rrd.com > > http://www.rrdonnelley.com > > > > > > > > > > On Mon, Oct 21, 2013 at 11:32 AM, Stephen Frost <sfr...@snowman.net> > wrote: > >> > >> Nigel, > >> > >> * Nigel Heron (nhe...@querymetrics.com) wrote: > >> > Hi, I've been using postgres for many years but never took the time to > >> > play > >> > with the code until now. As a learning experience i came up with this > >> > WIP > >> > patch to keep track of the # of bytes sent and received by the server > >> > over > >> > it's communication sockets. Counters are kept per database, per > >> > connection > >> > and globally/shared. > >> > >> Very neat idea. Please add it to the current commitfest > >> (http://commitfest.postgresql.org) and, ideally, someone will get in > and > >> review it during the next CM. > >> > >> Thanks! > >> > >> Stephen > > > > >