Hi Amit. I gone through the mail thread discussion regarding this issue and reviewed you patch.
-- Patch get applied cleanly on Master branch -- Make and Make Install fine -- make check also running cleanly In the patch code changes looks good to me. This patch having two part: 1) Allowed TableOid system column in the CHECK constraint 2) Throw an error if other then TableOid system column in CHECK constraint. I noticed that you added test coverage for 1) but the test coverage for 2) is missing.. I added the test coverage for 2) in the attached patch. Marking this as Ready for committer. Regards, Rushabh On Sun, Sep 15, 2013 at 2:31 PM, Amit Kapila <amit.kapil...@gmail.com>wrote: > Bruce Momjian wrote: > On Sun, Jun 30, 2013 at 06:57:10AM +0000, Amit kapila wrote: > >> >> I have done the initial analysis and prepared a patch, don't know if > >> >> anything more I can do until > >> >> someone can give any suggestions to further proceed on this bug. > > > > > >So, I guess we never figured this out. > > > >> I can submit this bug-fix for next commitfest if there is no objection > for doing so. > >> What is your opinion? > > > Yes, good idea. > > I had rebased the patch against head and added the test case to validate > it. > I will upload this patch to commit fest. > > With Regards, > Amit Kapila. > EnterpriseDB: http://www.enterprisedb.com > > > -- > Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-hackers > > -- Rushabh Lathia www.EnterpriseDB.com
sys_col_constr_v2.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
