Amit Kapila escribió: > > On Friday, August 02, 2013 4:19 AM Michael Paquier wrote: > >On Fri, Aug 2, 2013 at 1:22 AM, Robert Haas <robertmh...@gmail.com> wrote: > >> On Sun, Jul 28, 2013 at 1:26 AM, Amit kapila <amit.kap...@huawei.com> > >> wrote: > >>> 2. Shouldn't function > >>> do_start_bgworker()/StartOneBackgroundWorker(void) be moved to > >>> bgworker.c > >>> as similar functions AutoVacWorkerMain()/PgArchiverMain() are in > >>> their respective files. > > >> Yes, perhaps so. Other votes? > > > StartOneBackgroundWorker uses StartWorkerNeeded and HaveCrashedWorker, and > > IMO, we should not expose that outside the postmaster. > > How about exposing Set/Get for these from bgworker?
That seems more mess than just keeping that function in postmaster.c. I agree with moving the other one. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
