On 06/29/2013 03:29 PM, Pavel Stehule wrote:
5. This patch has user visibility, i.e. now we are throwing an error
when
user only says "VARIADIC NULL" like:
select concat(variadic NULL) is NULL;
Previously it was working but now we are throwing an error. Well we are
now
more stricter than earlier with using VARIADIC + ANY, so I have no issue
as
such. But I guess we need to document this user visibility change. I
don't
know exactly where though. I searched for VARIADIC and all related
documentation says it needs an array, so nothing harmful as such, so you
can
ignore this review comment but I thought it worth mentioning it.
yes, it is point for possible issues in RELEASE NOTES, I am thinking ???
Well, writer of release notes should be aware of this. And I hope he will
be. So no issue.
Is the behaviour change really unavoidable? Is it really what we want?
Nobody seems to have picked up on this except the author and the
reviewer. I'd hate us to do this and then surprise people. I'm not sure
how many people are using VARIADIC "any", but I have started doing so
and expect to do so more, and I suspect I'm not alone.
cheers
andrew
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
