--On 8. Juli 2013 16:04:31 +0000 Dean Rasheed <dean.a.rash...@gmail.com> wrote:
* pg_relation_is_updatable is only available in 9.3, whereas psql may connect to older servers, so it needs to guard against that.
Oh of course, i forgot about this. Thanks for pointing out.
* If we're doing this, I think we should do it for auto-updatable views at the same time. There was concern that pg_relation_is_updatable() would end up opening every relation in the database, hammering performance. I now realise that these tab-complete queries have a limit (1000 by default) so I don't think this is such an issue. I tested it by creating 10,000 randomly named auto-updatable views on top of a table, and didn't see any performance problems. Here's an updated patch based on the above points.
Okay, are you adding this to the september commitfest? -- Thanks Bernd -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers