On 2013-06-15 11:36:54 -0700, Jeff Davis wrote: > On Fri, 2013-06-14 at 18:27 +0200, Andres Freund wrote: > > I'd like to see a comment around the memcpys in XLogSaveBufferForHint() > > that mentions that they are safe in a non std buffer due to > > XLogCheckBuffer setting an appropriate hole/offset. Or make an explicit > > change of the copy algorithm there. > > Done. > Also done.
Thanks! Looks good to me. > Patch attached. Also, since we branched, I think this should be > back-patched to 9.3 as well. Absolutely. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers