2013/2/23 Tom Lane <t...@sss.pgh.pa.us>: > Pavel Stehule <pavel.steh...@gmail.com> writes: >> 2013/2/23 Stephen Frost <sfr...@snowman.net>: >>> Why is that? lookup_function_oid() only collects the oid to pass to >>> get_create_function_cmd(), why not just issue one query to the backend? >>> And use PSQLexec() to boot and get --echo-hidden, etc, for free? And >>> eliminate the one-off error handling for just this case? > >> yes, we can do it. There is only one issue > >> routines for parsing function signature in regproc and regprocedure >> should be updated - and I would to get some agreement than I start to >> do modify core. > > Uh ... you seem to be asking for a blank check to modify regprocedure, > which is unlikely to be forthcoming. Why do you think these things need > to be changed, and to what?
If I understand well to request to remove "minimal_error_message" we need to have fault tolerant regprocedure. I am looking on this code now, and it is not easy as I though - there are two possible errors: not found or found more - so returning InvalidOid is not enough - and then some "new lookup" function is not simple or is ugly - and I am not sure, so cost is less than benefit. in this case. Regards Pavel > > regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
