On Thu, 2012-11-15 at 14:44 -0500, Robert Haas wrote: > I think this is broadly reasonable, but I'm not sure this part is a > good idea: > > +#ifdef USE_LDAP > +#ifndef WIN32 > +/* We use a deprecated function to keep the codepath the same as > win32. */ > +#define LDAP_DEPRECATED 1 > +#include <ldap.h> > +#else > +#include <winldap.h> > +#endif > +#endif > > Presumably if it's deprecated now, it might go away without notice, > and we shouldn't be relying on it to stick around.
This part was copied from auth.c; it's been like that forever. Since Windows has no support for URL parsing, this could actually be simplified as far as hba.c goes, but the underlying issue is a different battle. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers