On Saturday, October 20, 2012 12:37:54 AM Tom Lane wrote: > Andres Freund <and...@2ndquadrant.com> writes: > > So as far as I can see the new logic is correct? A quick look & test > > seems to confirm that. > > I think the real problem here is just that the code was trying to be too > specific, and while your version might be more correct it's not doing > anything to fix that misjudgment. We should just make the > CreateTableAsStmt case look like the ExplainStmt case, viz > > Assert(IsA(qry, Query)); > if (qry->commandType == CMD_UTILITY) > return UtilityContainsQuery(qry->utilityStmt); > return qry;
FWIW commit + general principle looks good to me. Andres -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
