I have a few comments about this patch:
I didn't like the fact that the checker calling infrastructure uses SPI instead of just a FunctionCallN to call the checker function. I think this should be easily avoidable. Second, I see that functioncmds.c gets a lot into trigger internals just to be able to figure out the function starting from a trigger name. I think it'd be saner to have a new function in trigger.c that returns the required function OID. I think CheckFunction would be clearer if the code to check multiple objects is split out into a separate subroutine. After CheckFunction there is a leftover function comment without any following function. There are other spurious hunks that add or remove single lines too (once in an otherwise untouched file). -- Álvaro Herrera <alvhe...@commandprompt.com> The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
