On Wed, Feb 15, 2012 at 7:28 PM, Tom Lane <t...@sss.pgh.pa.us> wrote:
> Alexander Korotkov <aekorot...@gmail.com> writes:
> > On Wed, Feb 15, 2012 at 4:26 PM, Heikki Linnakangas <
> > heikki.linnakan...@enterprisedb.com> wrote:
> >> So, I think we should go with your original fix and simply do nothing in
> >> gistRelocateBuildBuffersOnSpli**t() if the page doesn't have a buffer.
>
> > I agree.
>
> OK, I won't object.
>
So, I think we can just commit first version of fix now.
------
With best regards,
Alexander Korotkov.
*** a/src/backend/access/gist/gistbuildbuffers.c
--- b/src/backend/access/gist/gistbuildbuffers.c
***************
*** 607,617 **** gistRelocateBuildBuffersOnSplit(GISTBuildBuffers *gfbb, GISTSTATE *giststate,
if (!found)
{
/*
! * Node buffer should exist at this point. If it didn't exist before,
! * the insertion that caused the page to split should've created it.
*/
! elog(ERROR, "node buffer of page being split (%u) does not exist",
! blocknum);
}
/*
--- 607,616 ----
if (!found)
{
/*
! * Page without buffer could be produced by split of root page. So
! * we've just nothing to do here when there is no buffer.
*/
! return;
}
/*
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
