Alvaro Herrera <alvhe...@commandprompt.com> writes: > I didn't like the new cmdtrigger.h file. It's included by a lot of > other headers, and it's also itself including execnodes.h and > parsenodes.h which means practically the whole lot of the source tree > is included in turn. If you could split it, so that the struct > definition is in a different file that's only included by the few .c > files that actually use that struct, I'd be much happier.
I didn't realize that, thanks for reviewing! > ... after looking at it more closely, I think only this line needs to be > in a separate file: > > typedef struct CommandContextData *CommandContext; > > and that file is included by other headers; they don't need the function > declarations or the struct definition. I'll look into that tomorrow then. The same trick is already applied to Relation and RelationData (resp. in src/include/utils/relcache.h and src/include/utils/rel.h), and only now I understand why :) Regards, -- Dimitri Fontaine http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
