Hi! On Tue, Jan 17, 2012 at 23:07, Martin Pihlak <martin.pih...@gmail.com> wrote: >> I think the hook warrants a comment that, whether the messages will be >> seen, depends on the log_min_messages setting. > > Comment added.
Nice :) It seems you missed a comment, that the current implementation is also affected by client_min_messages. I think that being affected by client-specific settings is surprising. I would put the if(emit_log_hook) inside the existing if(edata->output_to_server) condition. Unless you have some reason to do it this way? Regards, Marti -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
