On Tue, Dec 6, 2011 at 16:17, Tom Lane <t...@sss.pgh.pa.us> wrote: > Magnus Hagander <mag...@hagander.net> writes: >> Throwing an error seems a lot more safe in this case than just >> returning NULL. Since it's a situtation that really shouldn't happen. >> Maybe an assert, but I think a regular ereport(ERROR) would be the >> best. > > Not an assert, since it's trivially user-triggerable.
Right. There is some nice precedent in the CREATE TABLESPACE command (though dependent on HAVE_SYMLINK and not HAVE_READLINK), so I'm just going to copy the error message from there. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
