Excerpts from Robert Haas's message of jue nov 17 17:51:06 -0300 2011: > The trouble is, I'm not quite sure how to do that. It seems like > permissions checks and lock-the-heap-for-this-index should be done in > RangeVarGetRelid() just after the block that says "if (retry)" and > just before the block that calls LockRelationOid(). That way, if we > end up deciding we need to retry the name lookup, we'll retry all that > other stuff as well, which is exactly right. The difficulty is that > different callers have different needs for what should go in that > space, to the degree that I'm a bit nervous about continuing to add > arguments to that function to satisfy what everybody needs. Maybe we > could make most of them Booleans and pass an "int flags" argument. > Another option would be to add a "callback" argument to that function > that would be called at that point with the relation, relId, and > oldRelId as arguments. Alternatively, we could just resign ourselves > to duplicating the loop in this function into each place in the code > that has a special-purpose requirement, but the function is complex > enough to make that a pretty unappealing prospect.
I'm for the callback. -- Álvaro Herrera <alvhe...@commandprompt.com> The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
