Hi, My apologies for a very late reply.
I agree the fix you applied is a better one. I have verified the fix by testing the 'postgresql-9.1.1-1-windows-x64' installer. Thank you. On Thu, Jul 14, 2011 at 7:23 PM, Magnus Hagander <mag...@hagander.net>wrote: > On Wed, Jun 15, 2011 at 10:53, Ahmed Shinwari <ahmed.shinw...@gmail.com> > wrote: > > Hi All, > > > > I faced a bug on Windows while connecting via SSPI authentication. I was > > able to find the bug and have attached the patch. Details listed below; > > > > Postgres Installer: Version 9.0.4 > > OS: Windows Server 2008 R2/Windows 7 > > <big snip> > > Thanks - great analysis! > > However, I think there is a better fix for this - simply moving a } > one line. In particular, I'm concerned about passing the same pointer > both as input and output to the function - I couldn't find anything in > the documentation saying this was safe (nor did I find anything saying > it's unsafe, but.) Especially since this code clearly behaves > different on different versions - I've been completely unable to > reproduce this on any of my test machines, but they are all Windows > Server 2003. > > So - attached is a new version of the patch, how does this look to > you? FYI, I've had Thom test this new version and it does appear to > work fine in his scenario. > > > -- > Magnus Hagander > Me: http://www.hagander.net/ > Work: http://www.redpill-linpro.com/ > > > -- > Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-hackers > > -- Ahmed Shinwari EnterpriseDB Corporation : www.enterprisedb.com The Enterprise Postgres Company
