On tis, 2011-10-18 at 01:07 -0700, Jeff Davis wrote: > On Sun, 2011-10-16 at 16:00 -0400, Tom Lane wrote: > > Jeff Davis <pg...@j-davis.com> writes: > > > On master, I see a minor test error (at least on my machine) as well as > > > a diff. Patch attached. > > > > Hmm, yeah, I forgot to fix this regression test when I added that DETAIL > > line. However, I don't see the need for fooling with the lc_time value? > > > > regards, tom lane > > Here is the diff that I'm seeing on master right now with: > > make -s check EXTRA_TESTS=collate.linux.utf8 > > If I qualify it as "tr_TR.UTF-8" it works. Perhaps I have something > misconfigured on my system (Ubuntu 11.10)? I just installed: > language-pack-de > language-pack-tr > language-pack-sv > > in an attempt to make the test work, and it works all except for that > lc_time settng.
I think the language-pack packages have nothing to do with it; they only supply translations. Possibly, things are set up so that only UTF-8 locales are installed by default. Since the collate.linux.utf8 requires a UTF-8 environment, it seems reasonable to use the tr_TR.UTF-8 locale for LC_TIME, instead of requiring an unrelated (ISO-8859-9) locale to be installed. So I think the change you propose is reasonable. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
