Heikki Linnakangas <heikki.linnakan...@enterprisedb.com> writes:
> * Have you tested this on an architecture with strict alignment? I don't
> see any alignment bugs, but I think there's a lot of potential for them..
Well, fwiw, this patch passes its regression tests on HPPA, except for this
which seems more to do with the already-noted unacceptable dependency on
non-C collations:
*** /home/postgres/pgsql/src/test/regress/expected/rangetypes.out Fri Oct
14 21:19:19 2011
--- /home/postgres/pgsql/src/test/regress/results/rangetypes.out Fri Oct
14 21:50:11 2011
***************
*** 842,857 ****
--
create type textrange_c as range(subtype=text, collation="C");
create type textrange_en_us as range(subtype=text, collation="en_US");
select textrange_c('a','Z') @> 'b'::text;
ERROR: range lower bound must be less than or equal to range upper bound
select textrange_en_us('a','Z') @> 'b'::text;
! ?column?
! ----------
! t
! (1 row)
!
drop type textrange_c;
drop type textrange_en_us;
--
-- Test out polymorphic type system
--
--- 842,858 ----
--
create type textrange_c as range(subtype=text, collation="C");
create type textrange_en_us as range(subtype=text, collation="en_US");
+ ERROR: collation "en_US" for encoding "SQL_ASCII" does not exist
select textrange_c('a','Z') @> 'b'::text;
ERROR: range lower bound must be less than or equal to range upper bound
select textrange_en_us('a','Z') @> 'b'::text;
! ERROR: function textrange_en_us(unknown, unknown) does not exist
! LINE 1: select textrange_en_us('a','Z') @> 'b'::text;
! ^
! HINT: No function matches the given name and argument types. You might need
to add explicit type casts.
drop type textrange_c;
drop type textrange_en_us;
+ ERROR: type "textrange_en_us" does not exist
--
-- Test out polymorphic type system
--
======================================================================
Also, I notice you forgot to update serial_schedule:
diff --git a/src/test/regress/serial_schedule b/src/test/regress/serial_schedule
index bb654f9c612970ef777e8cc39369a91e343f6afc..2e87d9eefd6fbb70a5603bc000ffe833
5945201f 100644
*** a/src/test/regress/serial_schedule
--- b/src/test/regress/serial_schedule
*************** test: txid
*** 18,23 ****
--- 18,24 ----
test: uuid
test: enum
test: money
+ test: rangetypes
test: strings
test: numerology
test: point
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
