On Tue, Sep 6, 2011 at 12:00 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > [ Sorry for letting this slip through the cracks ... I think I got > distracted by collation bugs :-( ] > > Noah Misch <n...@leadboat.com> writes: >> On Sat, Mar 12, 2011 at 12:44:29PM -0500, Tom Lane wrote: >>> Noah Misch <n...@leadboat.com> writes: >>>> A suitably-instrumented run of "make installcheck-world" under valgrind >>>> turned >>>> up a handful of memory-related bugs: > >>> Hmm, interesting work, but I don't think I believe in the necessity for >>> this kluge: >>> >> + else if (attributeName != &(att->attname)) >> + namestrcpy(&(att->attname), attributeName); > > I'm still of the opinion that there's no real need to avoid memcpy with > identical source and destination, so I didn't apply this first patch.
I am leery of memcpy with overlapping regions. I know that it can cause an infinite loop on ssse3 architectures, having to do with some backwards-iteration it does: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/609290 I have spotted this in the wild in PostgreSQL (which is how I happened to produce this bug report link so readily), yet very rarely; I mailed a more detailed report to the security list. -- fdr -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
