2011/6/13 Shigeru Hanada <shigeru.han...@gmail.com>: > Thanks for the review. > > (2011/06/12 13:21), Robert Haas wrote: >> 2011/6/9 Shigeru Hanada<han...@metrosystems.co.jp>: >>> Attached patch includes fixes for FOREIGN TABLE documents: >> >> I committed the changes to ALTER FOREIGN TABLE, but I think the >> changes to CREATE FOREIGN TABLE need more thought. The first of the >> two hunks you've proposed to add doesn't seem necessary to me, and the >> second one seems like it belongs in a chapter on how to write a >> foreign data wrapper correctly, rather than here. > > Agreed. How about the section for IterateForeignScan() in "50.1. > Foreign Data Wrapper Callback Routines"[1] for the second hunk? It > seems proper place to describe responsibility about applying NOT NULL > constraint, because it would be where the author works for the issue. > The section also mentions responsibility of column signature matching. > > By the way, I found another document issue. "5.10. Foreign Data"[2] says > that FDW for PG is available alike FDW for files, but postgresql_fdw > won't be available for 9.1 release, at least as a bundled extension. > ISTM that such mention should be removed to avoid misunderstanding. > > Please find attached the revised patch.
Committed, with some additional word-smithing. Incidentally, are you planning to revive the PostgreSQL FDW for 9.2? That would be a killer feature. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
