Tom Lane wrote: > Bruce Momjian <br...@momjian.us> writes: > > I have applied the attached patch to fix pg_upgrade file descriptor > > leaks in error paths. > > It seems rather pointless to spend code closing descriptors immediately > before a fatal exit.
Well, it is not before a fatal but rather before it returns -1, which might fatal or might not. I also had code in to close file descriptors that was a little too tricky about using a single variable to indicate two things so I cleaned it up. I got a private email report about these so obviously they were confusing. -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers