On Fri, Feb 4, 2011 at 1:54 PM, Hitoshi Harada <umi.tan...@gmail.com> wrote: > 2011/2/5 Tom Lane <t...@sss.pgh.pa.us>: >> Hitoshi Harada <umi.tan...@gmail.com> writes: >>> 2011/2/5 Tom Lane <t...@sss.pgh.pa.us>: >>>> Yeah, putting backend-only stuff into that header is a nonstarter. >> >>> Do you mean you think it' all right to define >>> pg_cached_encoding_conversion() in pg_conversion_fn.h? >> >> That seems pretty random too. I still think you've designed this API >> badly and it'd be better to avoid exposing the FmgrInfo to callers >> by letting the function manage the cache internally. > > I'll try it in a few days, but only making struct that holds FmgrInfo > in a file local like tuplestorestate comes up with so far....
We've been through several iterations of this patch now and haven't come up with something committable. I think it's time to mark this one Returned with Feedback and revisit this for 9.2. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
