Excerpts from Magnus Hagander's message of mar ene 18 10:47:03 -0300 2011:
> Ok, thanks for clarifying. I've updated to use strerror(). Guess it's
> time for another patch, PFA :-)
Thanks ... Message nitpick:
+ if (compresslevel > 0)
+ {
+ fprintf(stderr,
+ _("%s: this build does not support compression\n"),
+ progname);
+ exit(1);
+ }
pg_dump uses the following wording:
"WARNING: archive is compressed, but this installation does not support "
"compression -- no data will be available\n"
So perhaps yours should s/build/installation/
Also, in messages of this kind,
+ if (gzsetparams(ztarfile, compresslevel, Z_DEFAULT_STRATEGY) !=
Z_OK)
+ {
+ fprintf(stderr, _("%s: could not set compression level
%i\n"),
+ progname, compresslevel);
Shouldn't you also be emitting the gzerror()? ... oh I see you're
already doing it for most gz calls.
--
Álvaro Herrera <alvhe...@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
