On 18.01.2011 07:15, Jim Nasby wrote:
Shouldn't the comment read "If first time through"?/* * If not first time through, get workspace to remember main XIDs in. We * malloc it permanently to avoid repeated palloc/pfree overhead. */ if (xids == NULL) { ... xids = (TransactionId *) malloc(maxxids * sizeof(TransactionId));
Huh, yes, I'm amazed that no-one have noticed. I must've read that piece of code dozens of times in the last couple of years myself, and that sentence was even copy-pasted to GetConflictingVirtualXIDs() later in that file, including that thinko.
Thanks, fixed both copies. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
