On Fri, Dec 3, 2010 at 2:23 PM, Peter Eisentraut <pete...@gmx.net> wrote: > On sön, 2010-11-28 at 20:40 -0500, Robert Haas wrote: >> On Sun, Nov 28, 2010 at 8:06 PM, Itagaki Takahiro >> <itagaki.takah...@gmail.com> wrote: >> > On Fri, Nov 26, 2010 at 05:58, Steve Singer <ssin...@ca.afilias.info> >> > wrote: >> >> The attached version of the patch gets your regression tests to pass. >> >> I'm going to mark this as ready for a committer. >> > >> > I think we need more discussions about the syntax: >> > ALTER TABLE table_name ADD PRIMARY KEY (...) WITH (INDEX='index_name') >> >> Why not: >> >> ALTER TABLE table_name ADD PRIMARY KEY (...) INDEX index_name; > > I would think that that determines that name of the index that the > command creates. It does not convey that an existing index is to be > used.
Well, that'll become clear pretty quickly if you try to use it that way, but I'm certainly open to other ideas. Random thoughts: ALTER TABLE table_name SET PRIMARY KEY INDEX index_name ALTER INDEX index_name PRIMARY KEY Other suggestions? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
