On Tue, Nov 30, 2010 at 08:13:37PM +0900, Itagaki Takahiro wrote: > On Tue, Nov 30, 2010 at 18:18, David Fetter <da...@fetter.org> wrote: > >> It expands all tables (and views) in tab-completion after INSERT, > >> UPDATE, and DELETE FROM. Is it an intended change? > > I found it was a simple bug; we need ( ) around selcondition.
Oh. Heh. Thanks for tracking this down. > In addition, I modified your patch a bit: > > * I added a separated CREATE TRIGGER INSTEAD OF if-branch > because it doesn't accept tables actually; it only accepts > views. OTOH, BEFORE or AFTER only accepts tables. OK > * I think "t.tgtype & (1 << N) <> 0" is more natural > bit operation than "t.tgtype | (1 << N) = t.tgtype". OK > Patch attached. If you think my changes are ok, > please change the patch status to "Ready for Committer". Done :) Cheers, David. -- David Fetter <da...@fetter.org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fet...@gmail.com iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
