Excerpts from Tom Lane's message of jue nov 25 13:23:42 -0300 2010: > Robert Haas <robertmh...@gmail.com> writes: > > No, what I was suggesting was taking the existing function: > > extern void pgstat_report_waiting(bool waiting); > > ...and instead doing something like this: > > extern void pgstat_report_waiting(char *reason); > > ...and then arrange to pass the reason via the eponymous argument. > > The question is how many cycles are we willing to expend on preparing a > reason string that (in approximately 99.9% of the calls) will not be > of any use. It would be much better to avoid doing this and instead > expend the extra work on the inspection side.
I'm all for making this cheap -- and your proposal works for tuple locks (ugly however it may be). But it doesn't work for "snapshot" locks such as the ones CREATE INDEX CONCURRENTLY takes. -- Álvaro Herrera <alvhe...@commandprompt.com> The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
