On Sat, Nov 20, 2010 at 1:37 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Robert Haas <robertmh...@gmail.com> writes: >> On Sat, Nov 20, 2010 at 1:01 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> But if you're going to do that, get rid of DoneMatchingIndexKeys >>> altogether, > >> Sure. That's a giant crock. > >>> along with the extra zero that plancat.c adds to the >>> opfamily array. We don't need to be using more than one way to >>> iterate over those arrays. > >> I am slightly worried that this might break third-party code, or even >> some part of the core code that's still using the old system. I don't >> mind if you want to rip it out, but personally, I'd rather leave that >> part well enough alone. Revised patch attached. > > I'll take the responsibility if you don't want to ;-)
Sold! :-) > I think your revised patch is incorrect, or at least not terribly safe, > to just remove the last DoneMatchingIndexKeys test and not replace it > with anything else. Other than that it looks okay as far as it goes. > Do you want to commit it yourself, or shall I incorporate it in a more > extensive cleanup? If it's all right with you, I'll go ahead and commit this and then you can break as much more stuff as you like. :-) -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
