On 10/15/2010 04:33 AM, Dean Rasheed wrote:
I started looking at this last night, but ran out of time. I'll continue this evening / over the weekend. Here are my comments so far: Patch applies cleanly to current git master with no offsets. Compiles cleanly with no warnings. Regression tests pass. The regression tests look reasonable, but I'd like to see a test of \dT+. Also it could be made to exercise the comparison function more if the test query did an ORDER BY CAST(enumlabel as planets). The docs for ALTER TYPE have been updated. I found a few minor typos, and also a couple of other sections of the manual that needed updating. Attached is an updated version with these changes. Andrew, let me know if you're happy with these tweaks and I'll continue reviewing over the weekend.
Thanks for the review. This looks good. cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
