On Sun, Sep 26, 2010 at 3:45 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Robert Haas <robertmh...@gmail.com> writes: >> Seems like it's probably a good idea, but I wanted to double-check >> that no one has a different thought. > > -1. If the lack of an ignore causes a problem for you, it indicates > that you're trying to commit code that fails the regression tests. > Is it really a good idea to let that happen without any manual cleanup?
I think it just means that the regression tests have failed at some point since the last time you cleaned out your tree. Those files don't get removed on a successful make check, do they? The reason I assumed we'd want to ignore these is because they're automatically generated files - unlike *.rej files, which are never going to end up in your tree as a result of make anything. It doesn't actually matter that much to me in practice, except that I fear creating a complex and indecipherable rule about what to ignore vs. not. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
