2010/9/22 Pavel Stehule <pavel.steh...@gmail.com>: > 2010/9/21 Robert Haas <robertmh...@gmail.com>: >> On Tue, Sep 21, 2010 at 4:28 PM, Pavel Stehule <pavel.steh...@gmail.com> >> wrote: >>>> * Cosmetic coding style should be more appropriate, including trailing >>>> white spaces and indentation positions. >>> >>> can you specify where, please? >> >> I noticed a lot of problems in this area when working on your \ef / >> \sf patch, too. Trailing whitespace is nearly always bad, and it's >> not hard to find - just grep the diff for it. As for indentation, try >> to match the surrounding code. > > is updated patch better?
Better, but you should be more careful, for example, + tuplesort_performsort(aggstate->sortstate); + <-- 1 + while (tuplesort_getdatum(aggstate->sortstate, + true, + &value, &isNull)) For #1, please remove horizontal tabs in empty lines. Regards, -- Hitoshi Harada -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
