On Tue, Sep 14, 2010 at 8:44 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Tue, Sep 14, 2010 at 7:26 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> I wrote: >>> I think that it's probably sufficient to make remove_rel_from_query run >>> through the rel's joininfo list looking for pseudoconstant quals, and >>> push those back into the joininfo lists with a reduced join list. I >>> wonder though if there's a better way, or if there are related bugs >>> this fix won't cover. Any thoughts? >> >> On reflection I decided that outerjoin-delayed quals could probably have >> the same problem. I've changed the code so that all quals not clearly >> attached to the specific outer join we're removing will be modified to >> ensure they're still evaluated at the right time. > > Thanks for jumping on this. FTR, I don't read pgsql-sql.
One other thought: should we add some of these queries that have exposed bugs in join removal to the regression tests? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
