On Fri, May 7, 2010 at 10:44 AM, Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > Excerpts from Robert Haas's message of vie may 07 07:33:55 -0400 2010: >> On Thu, May 6, 2010 at 3:29 PM, Andy Lester <a...@petdance.com> wrote: >> > I was looking for how to undo a CLUSTER call earlier today. Nothing on >> > the CLUSTER page told me how to do it, or pointed me to the ALTER TABLE >> > page. I figure a pointer to would help the next person in my situation. >> >> I've been annoyed by this too and so am in favor of adding a mention >> in the documentation, but I think we should mention both the CLUSTER >> and SET WITHOUT CLUSTER variants of ALTER TABLE, and since it's only >> one sentence I think we should add it adjacent to the existing >> sentence discussing remembering the index. My proposed patch >> attached; thoughts? > > dept. of minor nitpicks: > > change > + use <literal>CLUSTER</literal> or <literal>SET WITHOUT CLUSTER</literal> > > to > + use the <literal>CLUSTER ON</literal> or <literal>SET WITHOUT > CLUSTER</literal> > > Other than that, +1 from me. > > (Hmm, perhaps even say what each form is for right after mentioning it, > instead > of mentioning both and then saying what both are for.)
I couldn't think of a way to phrase that that was any better than the way I wrote it and still allowed me to include an xref to the ALTER TABLE page in a natural way. I am however open to suggestions. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
