On Tue, Apr 6, 2010 at 11:05 AM, Alvaro Herrera <alvhe...@commandprompt.com> wrote: > Joseph Adams escribió: > >> http://constellationmedia.com/~funsite/static/json-0.0.2.tar.bz2 >> >> My json.c is now 1161 lines long, so I can't quite call it "small" anymore. > > Just noticed you don't check the return value of malloc and friends. > How do you intend to handle that? There are various places that would > simply dump core with the 0.0.2 code. Within Postgres it's easy -- a > failed palloc aborts the transaction and doesn't continue running your > code. But in a standalone library that's probably not acceptable. > > If we were to import this there are some lines that could be ripped out, > like 60 lines in the string buffer stuff and 130 lines for Unicode. > That brings your code just under 1000 lines.
Let me be the first to suggest putting this code under the PostgreSQL license. ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
