David Fetter <da...@fetter.org> writes:
> -} elsif ($minor eq "devel") {
> - $dotneeded = 0;
> - $numericminor = 0;
> -} elsif ($minor =~ m/^alpha\d+$/) {
> - $dotneeded = 0;
> - $numericminor = 0;
> -} elsif ($minor =~ m/^beta\d+$/) {
> - $dotneeded = 0;
> - $numericminor = 0;
> -} elsif ($minor =~ m/^rc\d+$/) {
> +} elsif ($minor =~ m/
> + ^
> + (
> + devel |
> + alpha\d+ |
> + beta\d+ |
> + rc\d+
> + )
> + $/x) {
FWIW, I don't care for the above part of the patch. It doesn't seem to
me to improve readability one iota, if anything the reverse; and it
makes the logic less amenable to modification. If we wanted to make the
behavior at all different for alpha/beta/rc cases, we'd have to undo it
anyway.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
