Simon Riggs wrote: > On Thu, 2009-10-15 at 00:26 +0300, Peter Eisentraut wrote: > > On Wed, 2009-10-14 at 15:06 -0300, Alvaro Herrera wrote: > > > Simon Riggs wrote: > > > > > > > > When I run ./configure, I get > > > > > > > > (...warning..) > > > > (If you are using the official distribution of PostgreSQL then you do > > > > not need to worry about this because the Flex output is pre-generated.) > > > > > > > > Well, I am am using the official distribution of PostreSQL and the > > > > output is not pre-generated. Clearly this message only comes when you > > > > build Postgres from source, in which case the output cannot be > > > > pre-generated (can it?). > > > > > > I take it "official distribution" means "tarball" as different from a > > > copy obtained thru CVS. > > > > Maybe "If you are using an official release tarball of PostgreSQL", or > > "an official release source code archive of PostgreSQL" if we want to > > avoid the term "tarball". > > Something like... > > If you have downloaded a full copy of the source then.... > If you are building from a repository checkout ... > > We don't need to use the word tarball, but we do need to say what we > mean. Anyway, its a seldom-used error message and I wouldn't have hit it > if my laptop hadn't needed recovery.
With the attached patch, I have updated the message to use the wording "bundled distribution". I think the point about the snapshot tarballs and official releases is that they are "bundled" rather than pulled via CVS. -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do + If your life is a hard drive, Christ can be your backup. +
Index: configure =================================================================== RCS file: /cvsroot/pgsql/configure,v retrieving revision 1.673 diff -c -c -r1.673 configure *** configure 19 Feb 2010 18:42:29 -0000 1.673 --- configure 22 Feb 2010 17:56:52 -0000 *************** *** 6736,6748 **** { $as_echo "$as_me:$LINENO: WARNING: *** Without Bison you will not be able to build PostgreSQL from CVS nor *** change any of the parser definition files. You can obtain Bison from ! *** a GNU mirror site. (If you are using the official distribution of *** PostgreSQL then you do not need to worry about this, because the Bison *** output is pre-generated.)" >&5 $as_echo "$as_me: WARNING: *** Without Bison you will not be able to build PostgreSQL from CVS nor *** change any of the parser definition files. You can obtain Bison from ! *** a GNU mirror site. (If you are using the official distribution of *** PostgreSQL then you do not need to worry about this, because the Bison *** output is pre-generated.)" >&2;} fi --- 6736,6748 ---- { $as_echo "$as_me:$LINENO: WARNING: *** Without Bison you will not be able to build PostgreSQL from CVS nor *** change any of the parser definition files. You can obtain Bison from ! *** a GNU mirror site. (If you are using the bundled distribution of *** PostgreSQL then you do not need to worry about this, because the Bison *** output is pre-generated.)" >&5 $as_echo "$as_me: WARNING: *** Without Bison you will not be able to build PostgreSQL from CVS nor *** change any of the parser definition files. You can obtain Bison from ! *** a GNU mirror site. (If you are using the bundled distribution of *** PostgreSQL then you do not need to worry about this, because the Bison *** output is pre-generated.)" >&2;} fi *************** *** 6800,6812 **** { $as_echo "$as_me:$LINENO: WARNING: *** Without Flex you will not be able to build PostgreSQL from CVS nor *** change any of the scanner definition files. You can obtain Flex from ! *** a GNU mirror site. (If you are using the official distribution of *** PostgreSQL then you do not need to worry about this because the Flex *** output is pre-generated.)" >&5 $as_echo "$as_me: WARNING: *** Without Flex you will not be able to build PostgreSQL from CVS nor *** change any of the scanner definition files. You can obtain Flex from ! *** a GNU mirror site. (If you are using the official distribution of *** PostgreSQL then you do not need to worry about this because the Flex *** output is pre-generated.)" >&2;} --- 6800,6812 ---- { $as_echo "$as_me:$LINENO: WARNING: *** Without Flex you will not be able to build PostgreSQL from CVS nor *** change any of the scanner definition files. You can obtain Flex from ! *** a GNU mirror site. (If you are using the bundled distribution of *** PostgreSQL then you do not need to worry about this because the Flex *** output is pre-generated.)" >&5 $as_echo "$as_me: WARNING: *** Without Flex you will not be able to build PostgreSQL from CVS nor *** change any of the scanner definition files. You can obtain Flex from ! *** a GNU mirror site. (If you are using the bundled distribution of *** PostgreSQL then you do not need to worry about this because the Flex *** output is pre-generated.)" >&2;} *************** *** 6887,6898 **** { $as_echo "$as_me:$LINENO: WARNING: *** Without Perl you will not be able to build PostgreSQL from CVS. *** You can obtain Perl from any CPAN mirror site. ! *** (If you are using the official distribution of PostgreSQL then you do not *** need to worry about this, because the Perl output is pre-generated.)" >&5 $as_echo "$as_me: WARNING: *** Without Perl you will not be able to build PostgreSQL from CVS. *** You can obtain Perl from any CPAN mirror site. ! *** (If you are using the official distribution of PostgreSQL then you do not *** need to worry about this, because the Perl output is pre-generated.)" >&2;} fi --- 6887,6898 ---- { $as_echo "$as_me:$LINENO: WARNING: *** Without Perl you will not be able to build PostgreSQL from CVS. *** You can obtain Perl from any CPAN mirror site. ! *** (If you are using the bundled distribution of PostgreSQL then you do not *** need to worry about this, because the Perl output is pre-generated.)" >&5 $as_echo "$as_me: WARNING: *** Without Perl you will not be able to build PostgreSQL from CVS. *** You can obtain Perl from any CPAN mirror site. ! *** (If you are using the bundled distribution of PostgreSQL then you do not *** need to worry about this, because the Perl output is pre-generated.)" >&2;} fi Index: config/missing =================================================================== RCS file: /cvsroot/pgsql/config/missing,v retrieving revision 1.5 diff -c -c -r1.5 missing *** config/missing 23 Jun 2009 03:46:00 -0000 1.5 --- config/missing 22 Feb 2010 17:56:52 -0000 *************** *** 26,32 **** *** ERROR: \`$1' is missing on your system. It is needed to create the file \`$output'. You can either get $1 from a GNU mirror site ! or download an official distribution of PostgreSQL, which contains pre-packaged $1 output. ***" >&2 exit 1 --- 26,32 ---- *** ERROR: \`$1' is missing on your system. It is needed to create the file \`$output'. You can either get $1 from a GNU mirror site ! or download an bundled distribution of PostgreSQL, which contains pre-packaged $1 output. ***" >&2 exit 1 *************** *** 38,44 **** echo "\ *** ERROR: Perl is missing on your system. It is needed unless you are building ! from an unmodified official distribution of PostgreSQL. ***" >&2 exit 1 ;; --- 38,44 ---- echo "\ *** ERROR: Perl is missing on your system. It is needed unless you are building ! from an unmodified bundled distribution of PostgreSQL. ***" >&2 exit 1 ;; Index: config/perl.m4 =================================================================== RCS file: /cvsroot/pgsql/config/perl.m4,v retrieving revision 1.6 diff -c -c -r1.6 perl.m4 *** config/perl.m4 7 Jan 2010 01:41:11 -0000 1.6 --- config/perl.m4 22 Feb 2010 17:56:52 -0000 *************** *** 26,32 **** AC_MSG_WARN([ *** Without Perl you will not be able to build PostgreSQL from CVS. *** You can obtain Perl from any CPAN mirror site. ! *** (If you are using the official distribution of PostgreSQL then you do not *** need to worry about this, because the Perl output is pre-generated.)]) fi ])# PGAC_PATH_PERL --- 26,32 ---- AC_MSG_WARN([ *** Without Perl you will not be able to build PostgreSQL from CVS. *** You can obtain Perl from any CPAN mirror site. ! *** (If you are using the bundled distribution of PostgreSQL then you do not *** need to worry about this, because the Perl output is pre-generated.)]) fi ])# PGAC_PATH_PERL Index: config/programs.m4 =================================================================== RCS file: /cvsroot/pgsql/config/programs.m4,v retrieving revision 1.26 diff -c -c -r1.26 programs.m4 *** config/programs.m4 13 Jul 2009 05:36:53 -0000 1.26 --- config/programs.m4 22 Feb 2010 17:56:52 -0000 *************** *** 29,35 **** AC_MSG_WARN([ *** Without Bison you will not be able to build PostgreSQL from CVS nor *** change any of the parser definition files. You can obtain Bison from ! *** a GNU mirror site. (If you are using the official distribution of *** PostgreSQL then you do not need to worry about this, because the Bison *** output is pre-generated.)]) fi --- 29,35 ---- AC_MSG_WARN([ *** Without Bison you will not be able to build PostgreSQL from CVS nor *** change any of the parser definition files. You can obtain Bison from ! *** a GNU mirror site. (If you are using the bundled distribution of *** PostgreSQL then you do not need to worry about this, because the Bison *** output is pre-generated.)]) fi *************** *** 91,97 **** AC_MSG_WARN([ *** Without Flex you will not be able to build PostgreSQL from CVS nor *** change any of the scanner definition files. You can obtain Flex from ! *** a GNU mirror site. (If you are using the official distribution of *** PostgreSQL then you do not need to worry about this because the Flex *** output is pre-generated.)]) --- 91,97 ---- AC_MSG_WARN([ *** Without Flex you will not be able to build PostgreSQL from CVS nor *** change any of the scanner definition files. You can obtain Flex from ! *** a GNU mirror site. (If you are using the bundled distribution of *** PostgreSQL then you do not need to worry about this because the Flex *** output is pre-generated.)])
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers