2010/1/2 Tom Lane <t...@sss.pgh.pa.us>: > Pavel Stehule <pavel.steh...@gmail.com> writes: >> a) print correct message and exit(1) > > Which part of "no, you're not doing that" wasn't clear to you? >
> The error handling in this function should be no different from that > in the existing escaping functions. exit(1) is completely unacceptable. > Are we talking we about error handling in psql lexer? What I know, in psql there are no any escaping function now. Yes, exit(1) is maybe too hard - but it is safe. I didn't write PQescapeStringConn function, and I am not able to speak, we can ignore this error result. Full handling of this possible error, means to add some CHECK over any lexer call. Pavel > regards, tom lane > -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
