Tom Lane wrote:
Marko Tiikkaja <marko.tiikk...@cs.helsinki.fi> writes:
Tom Lane wrote:
This doesn't really seem like a good idea from here. You're changing
a decision that has something like twenty years' standing in the code,
for no real gain. AFAICS this is just going to move the special cases
from point A to point B.
Right, but this way you only have to special-case in grouping_planner(),
and targetList always means the same thing.
If you think that, it just means you have not found all the places you
need to special-case ;-). One really obvious example is ruleutils.c,
and I rather imagine there are multiple places in the parser and
rewriter that would need attention, quite aside from whatever it does
to the planner.
Of course there were multiple places that needed attention, but those
don't look like special-casing to me, they just have to make sure to do
what they need to on the correct list of those two, which is what they
did before.
I wouldn't care for this at all, but with things the way they are right
now, the writeable CTE patch has to do quite a few of these:
List *cteList;
if (query->cmdType != CMD_SELECT)
cteList = query->returningList;
else
cteList = query->targetList;
/* do something with cteList */
With this patch, they could use targetList directly without paying any
attention to the type of the Query inside them.
Regards,
Marko Tiikkaja
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
