Tom Lane wrote: > Alvaro Herrera <alvhe...@commandprompt.com> writes: > > Tom Lane wrote: > >> ... For the moment I've worked > >> around this by putting the typedef into nodes/params.h itself, but I > >> can't say I find that a pleasing solution. Has anyone got a better > >> idea? Should we make a parser/something header that just provides that > >> typedef? > > > Hmm ... if you create the new include file, is that going to avoid > > having to include params.h in plancache.h? > > Well, it'd include the new file instead of params.h.
It would be a problem if params.h included some other stuff, but since it's standalone I can't say it's a problem. > > If not, I don't think there's much point in having a new file (other > > than the typedef just not fitting in params.h). > > Yeah, what's bothering me is that it just doesn't fit there --- doesn't > seem to satisfy the POLA. But I guess there are plenty of bigger > issues than that in our code base. Yeah. -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
