On Tue, Oct 13, 2009 at 05:08:20PM -0400, Tom Lane wrote: > Roger Leigh <rle...@codelibre.net> writes: > > The attached updated patch renames all user-visible uses of > > "utf8" to "unicode". It also updates the documentation > > regarding "locale" to "psql client character set encoding" > > so the docs now match the code exactly. > > Applied with light editorialization. The main non-cosmetic change > I made was to postpone selection of default line_style until runtime > (see get_line_style() in the committed patch). The original coding > required knowledge of the line_style default rule not only in three > different places in psql, but in every other place using print.c, > such as createlang/droplang -l (which dumped core with the patch as > submitted). I changed it so that leaving line_style NULL implies > the default encoding-driven behavior, so that we don't need to touch > any of the callers.
Thanks. I agree with your improvement in get_line_style(), it's cleaner this way; I didn't realise print.c was used by the other programs, sorry about that. Regards, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linux http://people.debian.org/~rleigh/ `. `' Printing on GNU/Linux? http://gutenprint.sourceforge.net/ `- GPG Public Key: 0x25BFB848 Please GPG sign your mail.
signature.asc
Description: Digital signature
