On Tue, Sep 29, 2009 at 11:29 AM, Alvaro Herrera <alvhe...@commandprompt.com> wrote: > Marko Tiikkaja escribió: >> Robert Haas wrote: >> >So I think we should at a minimum ask the patch author to (1) fix the >> >explain bugs I found and (2) update the README, as well as (3) revert >> >needless whitespace changes - there are a couple in execMain.c, from >> >the looks of it. >> >> In the attached patch, I made the changes to explain as you >> suggested and reverted the only whitespace change I could find from >> execMain.c. However, English isn't my first language so I'm not very >> confident about fixing the README. > > BTW what was the conclusion of the idea about having three separate > nodes Insert, Delete, Update instead of a single Dml node?
It wasn't obvious from reading the patch why multiple node types would be superior; but I'm not 100% sure I understand what Tom had in mind, either. ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers