Tom Lane escribió: > Alvaro Herrera <alvhe...@commandprompt.com> writes: > > I think having schemapg.h be autogenerated is a good idea, so I stripped > > that from Robert Haas' patch. Here's the result. This should be > > relatively uncontroversial since, well, the controversial stuff has been > > stripped. The one problem is that it introduces more complex code than > > it removes dull declarations. > > Indeed, and it fails to get rid of all the dull declarations :-(.
Right. I don't think we're going to move forward if we only accept giant steps at a time, and we simultaneously reject patches that are too intrusive. What this says is that we're going to need to accept that a first change to the file generation system is going to be a dwarf step forward; otherwise we're going to stay right where we arej with which I'm not terribly happy. > I thought the idea was to generate all this stuff directly from the C > struct declarations (plus some hardwired knowledge about the > datatypes, comparable to what is in TypInfo in bootstrap.c already). > Removing four out of six Schema_pg_xxx macros while leaving the > equivalent DATA declarations behind isn't my idea of a major step > forward. Hmm, perhaps that's workable. I'll have a look around. -- Alvaro Herrera http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
