On Friday 17 July 2009 18:26:31 Fernando Ike wrote:
>    Follow new version patch, now with version postgresql version.

1) This is obviously wrong:

CASE WHEN l.lanispl = 't' THEN 'Trusted' WHEN l.lanispl = 'f' THEN 'Untrusted' 
END

2) It may be better to use lanispl to determine whether a language is a system 
object or not.  It's kind of obscure, but pg_dump does it that way, so it'd at 
least be consistent.

3) Your code does processSQLNamePattern(), but neither the help nor the 
documentation mention that \dL accepts a pattern.  A pattern for listing 
languages might be overkill, but at least the documentation needs to match 
what the code attempts to do.

4) Instead of LEFT JOIN pg_catalog.pg_proc p on l.lanplcallfoid = p.oid etc, 
just cast the oid field to regprocedure.  See examples elsewhere in 
describe.c.

Please submit an updated patch.

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to