Fujii Masao wrote:
Hi,
On Wed, Apr 8, 2009 at 6:56 AM, Guillaume Smet <guillaume.s...@gmail.com> wrote:
On Fri, Apr 3, 2009 at 5:42 AM, Fujii Masao <masao.fu...@gmail.com> wrote:
Here is the patch;
- Smart failover is chosen if the trigger file labeled "smart" or
an empty one exists.
- Fast failover is chosen if the trigger file labeled "fast" exists,
the signal (SIGUSR1 or SIGINT) is received or the wait timeout
happens.
After some further thoughts, +1 for this approach too.
I think you imply 'containing "smart"' not 'labeled "smart"'.
"Labeled" is confusing IMHO.
Thanks for the comment!
I corrected such confusing expression.
+ if (strspn(buf, "smart") == 5 && strncmp(buf, "smart", 5) == 0)
+ {
The strspn() call seems pointless here.
One problem with this patch is that in smart mode, the trigger file is
not deleted. That's different from current pg_standby behavior, and
makes accidental failovers after one failover more likely.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
